amogh-jahagirdar commented on code in PR #5618:
URL: https://github.com/apache/iceberg/pull/5618#discussion_r997564163
##########
core/src/test/java/org/apache/iceberg/TestDeleteFiles.java:
##########
@@ -68,38 +68,46 @@ public class TestDeleteFiles extends TableTestBase {
))
.build();
- @Parameterized.Parameters(name = "formatVersion = {0}")
+ private final String branch;
+
+ @Parameterized.Parameters(name = "formatVersion = {0}, branch = {1}")
public static Object[] parameters() {
- return new Object[] {1, 2};
+ return new Object[][] {
+ new Object[] {1, "main"},
+ new Object[] {1, "testBranch"},
+ new Object[] {2, "main"},
+ new Object[] {2, "testBranch"}
+ };
}
- public TestDeleteFiles(int formatVersion) {
+ public TestDeleteFiles(int formatVersion, String branch) {
super(formatVersion);
+ this.branch = branch;
}
@Test
public void testMultipleDeletes() {
-
table.newAppend().appendFile(FILE_A).appendFile(FILE_B).appendFile(FILE_C).commit();
+ Snapshot append =
Review Comment:
Sure, I left it as is for now. I did add a new method for reading from the
metadata for the test cases which were doing that before just so it's
consistent (although as you said, it doesn't impact anything from a correctness
standpoint).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
