ajantha-bhat commented on code in PR #5392:
URL: https://github.com/apache/iceberg/pull/5392#discussion_r1000089334
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/actions/SparkBinPackStrategy.java:
##########
@@ -60,12 +59,8 @@ public Set<DataFile> rewriteFiles(List<FileScanTask>
filesToRewrite) {
tableCache.add(groupID, table);
manager.stageTasks(table, groupID, filesToRewrite);
- // Disable Adaptive Query Execution as this may change the output
partitioning of our write
Review Comment:
similar problems exist in `SparkSortStrategy` and `SparkZOrderStrategy`'s
`rewriteFiles()` too.
So, it makes sense to add a method in `RewriteDataFilesSparkAction` which
will return cloned spark session with disabled adaptive execution.
this new method can be called instead of `spark()` in these 3 places.
https://github.com/apache/iceberg/blob/master/spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteDataFilesSparkAction.java#L491-L501
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
