ajantha-bhat commented on code in PR #5392: URL: https://github.com/apache/iceberg/pull/5392#discussion_r1000092705
########## spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/actions/SparkBinPackStrategy.java: ########## @@ -60,12 +59,8 @@ public Set<DataFile> rewriteFiles(List<FileScanTask> filesToRewrite) { tableCache.add(groupID, table); manager.stageTasks(table, groupID, filesToRewrite); - // Disable Adaptive Query Execution as this may change the output partitioning of our write Review Comment: Instead of the new method, `Override` is also fine as @kbendick suggested because `spark()` is called only once per `RewriteDataFilesSparkAction` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org