manuzhang commented on code in PR #5392:
URL: https://github.com/apache/iceberg/pull/5392#discussion_r1001312229
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/actions/SparkZOrderStrategy.java:
##########
@@ -202,17 +202,14 @@ public Set<DataFile> rewriteFiles(List<FileScanTask>
filesToRewrite) {
tableCache().add(groupID, table());
manager().stageTasks(table(), groupID, filesToRewrite);
- // Disable Adaptive Query Execution as this may change the output
partitioning of our write
- SparkSession cloneSession = spark().cloneSession();
- cloneSession.conf().set(SQLConf.ADAPTIVE_EXECUTION_ENABLED().key(),
false);
-
+ SparkSession spark = spark();
Review Comment:
this is not cloning but `spark()` from `SparkSortStrategy`
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/actions/SparkZOrderStrategy.java:
##########
@@ -202,17 +202,14 @@ public Set<DataFile> rewriteFiles(List<FileScanTask>
filesToRewrite) {
tableCache().add(groupID, table());
manager().stageTasks(table(), groupID, filesToRewrite);
- // Disable Adaptive Query Execution as this may change the output
partitioning of our write
- SparkSession cloneSession = spark().cloneSession();
- cloneSession.conf().set(SQLConf.ADAPTIVE_EXECUTION_ENABLED().key(),
false);
-
+ SparkSession spark = spark();
Review Comment:
this is not cloning again but `spark()` from `SparkSortStrategy`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
