manuzhang commented on code in PR #5392:
URL: https://github.com/apache/iceberg/pull/5392#discussion_r1001322740
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteDataFilesSparkAction.java:
##########
@@ -185,6 +186,14 @@ public RewriteDataFiles.Result execute() {
}
}
+ @Override
+ protected SparkSession spark() {
Review Comment:
Good point. It looks there's no need for overriding this method but simply
cloning in the constructor of `RewriteDataFilesSparkAction`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
