rdblue commented on code in PR #6058:
URL: https://github.com/apache/iceberg/pull/6058#discussion_r1007067162
##########
core/src/main/java/org/apache/iceberg/BaseTableScan.java:
##########
@@ -135,11 +143,14 @@ public CloseableIterable<FileScanTask> planFiles() {
planningDuration.stop();
ScanReport scanReport =
ImmutableScanReport.builder()
- .projection(schema())
+ .schemaId(schema().schemaId())
+ .projectedFieldIds(projectedFieldIds)
+ .projectedFieldNames(projectedFieldNames)
.tableName(table().name())
.snapshotId(snapshot.snapshotId())
.filter(ExpressionUtil.sanitize(filter()))
.scanMetrics(ScanMetricsResult.fromScanMetrics(scanMetrics()))
+ .metadata(context().options())
Review Comment:
I think it's good to send those, but I wouldn't mix it into this PR to avoid
delays.
Why call this `metadata`? That seems to generic. Why not `options` since
that is what the scan is using?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
