rdblue commented on code in PR #6058:
URL: https://github.com/apache/iceberg/pull/6058#discussion_r1014193865
##########
core/src/main/java/org/apache/iceberg/BaseTableScan.java:
##########
@@ -141,6 +142,8 @@ public CloseableIterable<FileScanTask> planFiles() {
doPlanFiles(),
() -> {
planningDuration.stop();
+ Map<String, String> metadata =
Maps.newHashMap(context().options());
+ metadata.putAll(EnvironmentContext.get());
Review Comment:
Yes, but why mix the scan options and environment context together as
"metadata"? I thought your comment above was to say that it is helpful to mix
them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
