ajantha-bhat commented on code in PR #6090:
URL: https://github.com/apache/iceberg/pull/6090#discussion_r1014286079
##########
core/src/main/java/org/apache/iceberg/FileCleanupStrategy.java:
##########
@@ -79,4 +80,15 @@ protected void deleteFiles(Set<String> pathsToDelete, String
fileType) {
(file, thrown) -> LOG.warn("Delete failed for {} file: {}",
fileType, file, thrown))
.run(deleteFunc::accept);
}
+
+ protected Set<String> expiredStatisticsFilesLocations(
+ TableMetadata beforeExpiration, Set<Long> expiredIds) {
+ Set<String> expiredStatisticsFilesLocations = Sets.newHashSet();
+ for (StatisticsFile statisticsFile : beforeExpiration.statisticsFiles()) {
+ if (expiredIds.contains(statisticsFile.snapshotId())) {
+ expiredStatisticsFilesLocations.add(statisticsFile.path());
Review Comment:
@findepi: Thinking more about this, As the `TableMetadata` has just the list
of `StatisticsFile`. And you have mentioned, statisticsFile.snapshotId() is
"ID of the Iceberg table's snapshot the statistics were computed from"
So, how will the query knows which statistics file to use for the current
snapshot (Incase of rewrite data files, the current snapshot id may not be
present in that list of statistics file?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
