ajantha-bhat commented on code in PR #6090:
URL: https://github.com/apache/iceberg/pull/6090#discussion_r1044055824
##########
core/src/main/java/org/apache/iceberg/FileCleanupStrategy.java:
##########
@@ -83,4 +85,33 @@ protected void deleteFiles(Set<String> pathsToDelete, String
fileType) {
(file, thrown) -> LOG.warn("Delete failed for {} file: {}",
fileType, file, thrown))
.run(deleteFunc::accept);
}
+
+ protected Set<String> expiredStatisticsFilesLocations(
+ TableMetadata beforeExpiration, Set<Long> validIds, Set<Long>
expiredIds) {
+ Set<String> validStatisticsFilesLocation = Sets.newHashSet();
+ for (long snapshotId : validIds) {
+ List<StatisticsFile> statisticsFiles =
+ beforeExpiration.statisticsFilesForSnapshot(snapshotId);
+ if (statisticsFiles != null) {
+ statisticsFiles.forEach(file ->
validStatisticsFilesLocation.add(file.path()));
+ }
+ }
+
+ // Statistics files can be reused in case of rewrite data files.
Review Comment:
I can remove/update the comment.
But I just wanted to mention stats files can be reused (rewrite data files
is one of the scenarios). So, we can't blindly remove it without checking the
reachability graph.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
