LuigiCerone commented on code in PR #6159:
URL: https://github.com/apache/iceberg/pull/6159#discussion_r1020523338
##########
python/tests/avro/test_decoder.py:
##########
@@ -106,9 +107,11 @@ def read(self, size: int = 0) -> bytes:
self.pos += 1
return int.to_bytes(1, self.pos, byteorder="little")
+ @abstractmethod
Review Comment:
After the [update of
mypy](https://mypy-lang.blogspot.com/2022/11/mypy-0990-released.html), methods
with empty bodies are not allowed for type safety reasons. Either we turn the
class into an abstract one (but the test will fail for now because it has to be
readjusted) or we disable this new functionality with the specific flag
(`--allow-empty-bodies`). What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
