Fokko commented on code in PR #6159:
URL: https://github.com/apache/iceberg/pull/6159#discussion_r1020553202
##########
python/tests/avro/test_decoder.py:
##########
@@ -106,9 +107,11 @@ def read(self, size: int = 0) -> bytes:
self.pos += 1
return int.to_bytes(1, self.pos, byteorder="little")
+ @abstractmethod
Review Comment:
Ah, thanks for the explanation. I think it is okay to implement them. For
the seek we need to update the `self.pos` and for tell we need to return the
pos.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
