RussellSpitzer commented on code in PR #5376:
URL: https://github.com/apache/iceberg/pull/5376#discussion_r1024565829
##########
api/src/main/java/org/apache/iceberg/Schema.java:
##########
@@ -233,6 +233,16 @@ public Map<String, Integer> getAliases() {
return aliasToId;
}
+ /**
+ * Returns a map for this schema between field id and qualified field names.
Initializes the map,
+ * if it has not been initialized by calls to {@link #findColumnName(int)}.
+ *
+ * @return a map of field id to qualified field names
+ */
+ public Map<Integer, String> idToName() {
Review Comment:
I'm generally a bit nervous about expanding the api here, is this better
than just re-using findColumnName(id)?
That said I don't think lazyIdToName() is that dangerous, but the java doc
for this method contains a lot of very specific implementation details which
should probably be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
