RussellSpitzer commented on code in PR #5376:
URL: https://github.com/apache/iceberg/pull/5376#discussion_r1025805720
##########
core/src/main/java/org/apache/iceberg/BaseFilesTable.java:
##########
@@ -186,4 +224,43 @@ ManifestFile manifest() {
return manifest;
}
}
+
+ static class ContentFileStructWithMetrics implements StructLike {
+ private final int structSize;
+ private final StructLike fileAsStruct;
+ private final MetricsUtil.ReadableMetricsStruct readableMetrics;
+
+ ContentFileStructWithMetrics(
+ int structSize,
+ StructLike fileAsStruct,
+ MetricsUtil.ReadableMetricsStruct readableMetrics) {
+ this.structSize = structSize;
Review Comment:
Since we only use structSize -1, why not instead store (and change variable
name) to
```
lastStructIndex = fileAsStruct.size() - 1;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
