nastra commented on code in PR #6274:
URL: https://github.com/apache/iceberg/pull/6274#discussion_r1033276569
##########
core/src/main/java/org/apache/iceberg/ManifestEntry.java:
##########
@@ -103,27 +103,6 @@ default boolean isLive() {
*/
void setDataSequenceNumber(long dataSequenceNumber);
- /**
- * Returns the data sequence number of the file if the entry status is ADDED
or EXISTING.
- * Otherwise, returns the sequence number of the snapshot in which the file
was removed.
- *
- * <p>Note that usage of this method should be avoided as it behaves
inconsistently for different
- * entry statutes. Use {@link #dataSequenceNumber()} instead.
- *
- * @deprecated since 1.0.0, will be removed in 1.1.0; use {@link
#dataSequenceNumber()} instead.
- */
- @Deprecated
- Long sequenceNumber();
Review Comment:
@aokolnychyi could you please review all places that adjust sequenceNumber
-> dataSequenceNumber?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]