nastra commented on code in PR #6274:
URL: https://github.com/apache/iceberg/pull/6274#discussion_r1036809785
##########
core/src/main/java/org/apache/iceberg/deletes/Deletes.java:
##########
@@ -83,21 +83,6 @@ public static <T> CloseableIterable<T> markDeleted(
});
}
- /**
- * Returns the remaining rows (the ones that are not deleted), while
counting the deleted ones.
- *
- * @param rows the rows to process
- * @param isDeleted a predicate that determines if a row is deleted
- * @return the processed rows
- * @deprecated Will be removed in 1.2.0, use {@link
Deletes#filterDeleted(CloseableIterable,
- * Predicate, DeleteCounter)}.
- */
- @Deprecated
- public static <T> CloseableIterable<T> filterDeleted(
Review Comment:
This is functionality that was adjusted by #4588. We then re-introduced +
deprecated the method in #6146 to not have breaking API changes. Also there's
currently no place in the code that would use this, so it seems better to
remove it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
