ajantha-bhat commented on code in PR #6250:
URL: https://github.com/apache/iceberg/pull/6250#discussion_r1039831769


##########
docs/spark-getting-started.md:
##########
@@ -57,8 +57,6 @@ This command creates a path-based catalog named `local` for 
tables under `$PWD/w
 ```sh
 spark-sql --packages org.apache.iceberg:iceberg-spark-runtime-3.2_2.12:{{% 
icebergVersion %}}\
     --conf 
spark.sql.extensions=org.apache.iceberg.spark.extensions.IcebergSparkSessionExtensions
 \
-    --conf 
spark.sql.catalog.spark_catalog=org.apache.iceberg.spark.SparkSessionCatalog \

Review Comment:
   which one can be better?
   a) Remove "built-in catalog" mentioned from the line 55 
   b) or change  `spark_catalog` type also to `Hadoop`
   c) or add some hive URI = xxxxxx in the example snippet 
   
   I don't think we can leave it as it is because the catalog-type is hive but 
without URI will just confuse the users. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to