RussellSpitzer commented on code in PR #6250:
URL: https://github.com/apache/iceberg/pull/6250#discussion_r1039836905
##########
docs/spark-getting-started.md:
##########
@@ -57,8 +57,6 @@ This command creates a path-based catalog named `local` for
tables under `$PWD/w
```sh
spark-sql --packages org.apache.iceberg:iceberg-spark-runtime-3.2_2.12:{{%
icebergVersion %}}\
--conf
spark.sql.extensions=org.apache.iceberg.spark.extensions.IcebergSparkSessionExtensions
\
- --conf
spark.sql.catalog.spark_catalog=org.apache.iceberg.spark.SparkSessionCatalog \
Review Comment:
"spark_catalog" is the built in catalog for Spark. The one you get without
specifying anything else. This configuration would work for any user who has
already defined a HMS for Spark and would like it to also work with Iceberg
Tables. So I would think this would be useful to most folks who are using
Iceberg with an existing Spark Setup.
I think it's fine to skip "spark_catalog" in this particular usage though
since all the examples use a separate "local" SparkCatalog. If we remove it we
should probably add some more details SparkSessionCatalog in some different
section perhaps? Or maybe add another example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
