krvikash opened a new pull request, #6499: URL: https://github.com/apache/iceberg/pull/6499
**Issue:** `checkCommitStatus` is not checking the NULL value for metadata. This will cause NPE when the commit fails for table operations while creating a new table with RuntimeException and the call goes to check the commit status via `checkCommitStatus`. Since the table might not be created then `refresh()` will return NULL. This PR fixes the issue when creating a new table fails to commit with RuntimeException. I am adding missing test cases as well for commit failure during table creation. Though I have a couple of questions. 1. Should we clean up the metadata file in case of createTable commit failure even if `commitStatus` is `UNKNOWN`? 2. Should we add test cases for every table operation? For now, test cases are added for Hive and Glue table operations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
