krvikash commented on code in PR #6499:
URL: https://github.com/apache/iceberg/pull/6499#discussion_r1069695013
##########
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCommits.java:
##########
@@ -307,6 +312,61 @@ public void testAlreadyExistsException() {
() -> catalog.createTable(TABLE_IDENTIFIER, schema,
PartitionSpec.unpartitioned()));
}
+ @Test
+ public void testCreateTableCommitFailure() throws TException,
InterruptedException {
Review Comment:
Thanks, @nastra for the review.
Yes, you are right `testCreateTableCommitFailure` will not reach
`checkCommitStatus `. I have not seen any test case which covers create table
failure which is why I have added this test case to verify the create table
failure where we are not required to check the commit status.
Now I have separated this change into a new commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
