rdblue commented on code in PR #6490:
URL: https://github.com/apache/iceberg/pull/6490#discussion_r1059524606
##########
python/pyiceberg/typedef.py:
##########
@@ -85,16 +86,24 @@ class Record(StructProtocol):
def __init__(self, *data: Union[Any, StructProtocol]) -> None:
self._data = list(data)
+ for idx, value in enumerate(data):
+ self[idx] = value
- def set(self, pos: int, value: Any) -> None:
+ def __setitem__(self, pos: int, value: Any) -> None:
Review Comment:
I like allowing the use of `__setitem__` and `__getitem__` but do we want to
make a breaking change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
