rdblue commented on code in PR #6490:
URL: https://github.com/apache/iceberg/pull/6490#discussion_r1059524781
##########
python/tests/expressions/test_visitors.py:
##########
@@ -827,85 +840,91 @@ def manifest_no_stats() -> ManifestFile:
return _to_manifest_file()
+def _PartitionFieldSummary(
+ contains_null: bool, contains_nan: Optional[bool], lower_bound:
Optional[bytes], upper_bound: Optional[bytes]
+) -> PartitionFieldSummary:
+ return PartitionFieldSummary.from_record(Record(contains_null,
contains_nan, lower_bound, upper_bound))
+
+
@pytest.fixture
def manifest() -> ManifestFile:
return _to_manifest_file(
# id
- PartitionFieldSummary(
+ _PartitionFieldSummary(
Review Comment:
Is it worth adding the `_` prefix? For records from the spec, I'd probably
omit it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
