rdblue commented on code in PR #6432:
URL: https://github.com/apache/iceberg/pull/6432#discussion_r1060864469


##########
core/src/main/java/org/apache/iceberg/deletes/Deletes.java:
##########
@@ -135,6 +141,11 @@ public static StructLikeSet toEqualitySet(
     }
   }
 
+  @VisibleForTesting
+  static void resetDeletePosThreadPool() {
+    deletePosThreadPool = ThreadPools.newDeleteWorkerPool();

Review Comment:
   I think it is better to allow tests to pass in a custom pool that is used 
and cleaned up rather than adding something that replaces the static pool.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to