rdblue commented on code in PR #6432:
URL: https://github.com/apache/iceberg/pull/6432#discussion_r1060864920
##########
core/src/main/java/org/apache/iceberg/deletes/Deletes.java:
##########
@@ -49,6 +53,8 @@ public class Deletes {
private static final Accessor<StructLike> POSITION_ACCESSOR =
POSITION_DELETE_SCHEMA.accessorForField(MetadataColumns.DELETE_FILE_POS.fieldId());
+ private static ExecutorService deletePosThreadPool =
ThreadPools.newDeleteWorkerPool();
Review Comment:
I think that this default pool should be managed by ThreadPools like the
worker pool, rather than using a ThreadPools factory method to create them. See
my comments in that class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
