jackye1995 commented on code in PR #6598: URL: https://github.com/apache/iceberg/pull/6598#discussion_r1070708365
########## api/src/main/java/org/apache/iceberg/view/ViewRepresentation.java: ########## @@ -19,14 +19,21 @@ package org.apache.iceberg.view; import java.util.Locale; +import org.immutables.value.Value; [email protected] public interface ViewRepresentation { enum Type { Review Comment: can we potentially avoid the enum type and directly use string? That seems to be able to simplify things a bit. (this should probably be asked in the API PR, but I guess it's still not too late). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
