amogh-jahagirdar commented on code in PR #6598: URL: https://github.com/apache/iceberg/pull/6598#discussion_r1070722634
########## api/src/main/java/org/apache/iceberg/view/ViewRepresentation.java: ########## @@ -19,14 +19,21 @@ package org.apache.iceberg.view; import java.util.Locale; +import org.immutables.value.Value; [email protected] public interface ViewRepresentation { enum Type { Review Comment: Agreed, see the discussion here on this topic of enums in the original API PR https://github.com/apache/iceberg/pull/4925/files#r1015167642 I think as long as we have well defined and documented type strings that should be acceptable. ########## api/src/main/java/org/apache/iceberg/view/ViewRepresentation.java: ########## @@ -19,14 +19,21 @@ package org.apache.iceberg.view; import java.util.Locale; +import org.immutables.value.Value; [email protected] public interface ViewRepresentation { enum Type { Review Comment: Agreed, see the discussion here on this topic of enums in the original API PR https://github.com/apache/iceberg/pull/4925/files#r1015167642 I think as long as we have well defined and documented type strings that should be acceptable. I'll update to use strings and we can get feedback from the community -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
