amogh-jahagirdar commented on code in PR #6638:
URL: https://github.com/apache/iceberg/pull/6638#discussion_r1083379723
##########
spark/v3.3/spark-extensions/src/main/antlr/org.apache.spark.sql.catalyst.parser.extensions/IcebergSqlExtensions.g4:
##########
@@ -74,6 +74,7 @@ statement
| ALTER TABLE multipartIdentifier SET IDENTIFIER_KW FIELDS fieldList
#setIdentifierFields
| ALTER TABLE multipartIdentifier DROP IDENTIFIER_KW FIELDS fieldList
#dropIdentifierFields
| ALTER TABLE multipartIdentifier CREATE BRANCH identifier (AS OF VERSION
snapshotId)? (RETAIN snapshotRefRetain snapshotRefRetainTimeUnit)?
(snapshotRetentionClause)? #createBranch
+ | ALTER TABLE multipartIdentifier REPLACE BRANCH identifier (AS OF VERSION
snapshotId)? (RETAIN snapshotRefRetain snapshotRefRetainTimeUnit)?
(snapshotRetentionClause)? #replaceBranch
Review Comment:
After writing this out, starting to change my mind :) maybe we combine
{CREATE | REPLACE} in the same definition if that's possible?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
