jackye1995 commented on code in PR #6638:
URL: https://github.com/apache/iceberg/pull/6638#discussion_r1085882026
##########
spark/v3.3/spark-extensions/src/main/antlr/org.apache.spark.sql.catalyst.parser.extensions/IcebergSqlExtensions.g4:
##########
@@ -82,6 +82,13 @@ snapshotRetentionClause
| WITH SNAPSHOT RETENTION numSnapshots SNAPSHOTS snapshotRetain
snapshotRetainTimeUnit
;
+createReplaceBranchClause
+ : (CREATE | REPLACE) BRANCH identifier branchOptions
+ ;
Review Comment:
I am okay if we just change this PR to just support all combinations. Based
on
https://docs.databricks.com/sql/language-manual/sql-ref-syntax-ddl-create-table-using.html,
we should do:
`{ { [CREATE OR] REPLACE BRANCH | CREATE BRANCH [ IF NOT EXISTS ] }`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
