RussellSpitzer commented on code in PR #6661:
URL: https://github.com/apache/iceberg/pull/6661#discussion_r1088136888
##########
core/src/main/java/org/apache/iceberg/PartitionsTable.java:
##########
@@ -47,7 +48,11 @@ public class PartitionsTable extends BaseMetadataTable {
Types.NestedField.required(1, "partition",
Partitioning.partitionType(table)),
Types.NestedField.required(2, "record_count",
Types.LongType.get()),
Types.NestedField.required(3, "file_count",
Types.IntegerType.get()),
- Types.NestedField.required(4, "spec_id", Types.IntegerType.get()));
Review Comment:
In the past we have general said that readers should not rely on position of
fields in tables, only on names. That said every time we do something like this
I think we end up breaking somebody.
If we are gonna move things it probably should go before file and record
count, though rather than after all the stats.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
