stevenzwu commented on code in PR #6660:
URL: https://github.com/apache/iceberg/pull/6660#discussion_r1088427398
##########
flink/v1.16/flink/src/test/java/org/apache/iceberg/flink/sink/TestTaskWriters.java:
##########
@@ -53,16 +53,17 @@ public class TestTaskWriters {
private static final long TARGET_FILE_SIZE = 128 * 1024 * 1024;
@Rule public final TemporaryFolder tempFolder = new TemporaryFolder();
+ private final String branch;
@Parameterized.Parameters(name = "format = {0}, partitioned = {1}")
public static Object[][] parameters() {
return new Object[][] {
- {"avro", true},
- {"avro", false},
- {"orc", true},
- {"orc", false},
- {"parquet", true},
- {"parquet", false}
+ {"avro", true, "main"},
Review Comment:
we probably shouldn't need to add the branch parameter here. this class is
mainly for testing Flink TaskWriter. branching or not is not really important.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
