amogh-jahagirdar commented on code in PR #6660:
URL: https://github.com/apache/iceberg/pull/6660#discussion_r1089737315
##########
flink/v1.16/flink/src/test/java/org/apache/iceberg/flink/sink/TestFlinkIcebergSink.java:
##########
@@ -85,28 +86,29 @@ public class TestFlinkIcebergSink {
private final int parallelism;
private final boolean partitioned;
- @Parameterized.Parameters(name = "format={0}, parallelism = {1}, partitioned
= {2}")
+ @Parameterized.Parameters(name = "format={0}, parallelism = {1}, partitioned
= {2}, branch = {3}")
Review Comment:
Sure, yeah for branch tests the total time increase would be 2x. In that
case, I will keep the current implementation which removes the extra dimension
and separates the branch specific tests. let me know your thoughts @stevenzwu !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
