RussellSpitzer commented on code in PR #6682:
URL: https://github.com/apache/iceberg/pull/6682#discussion_r1095925633
##########
api/src/main/java/org/apache/iceberg/actions/DeleteOrphanFiles.java:
##########
@@ -67,7 +67,11 @@ public interface DeleteOrphanFiles extends
Action<DeleteOrphanFiles, DeleteOrpha
*
* @param deleteFunc a function that will be called to delete files
* @return this for method chaining
+ * @deprecated Deletes are now performed in bulk see {@link
#deleteBulkWith(Consumer)}. This
Review Comment:
I think adding that keeping the other apis makes things a bit more
complicated. Let me try rewriting this a bit, but I think keeping deleteWith
and Execute with means necessarily having two sets of tests one for each
operation path. We could maybe get away with a single test for each of these
....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
