jackye1995 commented on code in PR #6660:
URL: https://github.com/apache/iceberg/pull/6660#discussion_r1103850488
##########
flink/v1.16/flink/src/test/java/org/apache/iceberg/flink/sink/TestIcebergFilesCommitter.java:
##########
@@ -76,22 +76,24 @@ public class TestIcebergFilesCommitter extends
TableTestBase {
private File flinkManifestFolder;
private final FileFormat format;
+ private final String branch;
- @Parameterized.Parameters(name = "FileFormat = {0}, FormatVersion={1}")
+ @Parameterized.Parameters(name = "FileFormat = {0}, FormatVersion = {1},
branch = {2}")
public static Object[][] parameters() {
return new Object[][] {
- new Object[] {"avro", 1},
- new Object[] {"avro", 2},
- new Object[] {"parquet", 1},
- new Object[] {"parquet", 2},
- new Object[] {"orc", 1},
- new Object[] {"orc", 2}
+ new Object[] {"avro", 1, "main"},
Review Comment:
Also similar to the comment in Spark
https://github.com/apache/iceberg/pull/6651/files#r1101939155, can we reduce
the number of combinations here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
