aokolnychyi commented on code in PR #6651: URL: https://github.com/apache/iceberg/pull/6651#discussion_r1105332211
########## spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkPositionDeltaWrite.java: ########## @@ -100,6 +100,7 @@ class SparkPositionDeltaWrite implements DeltaWrite, RequiresDistributionAndOrde private final Map<String, String> extraSnapshotMetadata; private final Distribution requiredDistribution; private final SortOrder[] requiredOrdering; + private final String branch; Review Comment: nit: Can the order of the fields match the order of initialization in the constructor? In other words, can we move `branch` just below `wapId`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
