rdblue commented on code in PR #6651:
URL: https://github.com/apache/iceberg/pull/6651#discussion_r1109148936
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkReadConf.java:
##########
@@ -83,7 +83,11 @@ public Long endSnapshotId() {
}
public String branch() {
- return
confParser.stringConf().option(SparkReadOptions.BRANCH).parseOptional();
+ return confParser
+ .stringConf()
+ .sessionConf(SparkReadOptions.BRANCH)
Review Comment:
@namrathamyske, what about adding back the write side? I think the problem
is just with the read side and we can't test the write side of this PR without
the SQL option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
