jackye1995 commented on code in PR #6807:
URL: https://github.com/apache/iceberg/pull/6807#discussion_r1106001997
##########
spark/v3.3/spark-extensions/src/main/antlr/org.apache.spark.sql.catalyst.parser.extensions/IcebergSqlExtensions.g4:
##########
@@ -76,6 +76,7 @@ statement
| ALTER TABLE multipartIdentifier createReplaceBranchClause
#createOrReplaceBranch
| ALTER TABLE multipartIdentifier createReplaceTagClause
#createOrReplaceTag
| ALTER TABLE multipartIdentifier DROP BRANCH (IF EXISTS)? identifier
#dropBranch
+ | ALTER TABLE multipartIdentifier DROP TAG (IF EXISTS)? identifier
#dropTag
Review Comment:
we discussed this in
https://github.com/apache/iceberg/pull/6637#discussion_r1083330167, and the
conclusion was that it is more clear to have them separated.
The current way for separated DROP BRANCH and DROP TAG makes the logic
consistent with CREATE.
Let me know what you think!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
