singhpk234 commented on code in PR #6807:
URL: https://github.com/apache/iceberg/pull/6807#discussion_r1106330792
##########
spark/v3.3/spark-extensions/src/main/antlr/org.apache.spark.sql.catalyst.parser.extensions/IcebergSqlExtensions.g4:
##########
@@ -76,6 +76,7 @@ statement
| ALTER TABLE multipartIdentifier createReplaceBranchClause
#createOrReplaceBranch
| ALTER TABLE multipartIdentifier createReplaceTagClause
#createOrReplaceTag
| ALTER TABLE multipartIdentifier DROP BRANCH (IF EXISTS)? identifier
#dropBranch
+ | ALTER TABLE multipartIdentifier DROP TAG (IF EXISTS)? identifier
#dropTag
Review Comment:
I see, was mostly coming from spark code base, considering this example :
https://github.com/apache/spark/blob/46a234125d3f125ba1f9ccd6af0ec1ba61016c1e/sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4#L125
If we have reached the concencus, then it should be fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
