nastra commented on code in PR #6835:
URL: https://github.com/apache/iceberg/pull/6835#discussion_r1108124042
##########
aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3ObjectMapper.java:
##########
@@ -48,13 +48,16 @@ public class S3ObjectMapper {
private S3ObjectMapper() {}
- static ObjectMapper mapper() {
+ public static ObjectMapper mapper() {
if (!isInitialized) {
synchronized (S3ObjectMapper.class) {
if (!isInitialized) {
MAPPER.setVisibility(PropertyAccessor.FIELD,
JsonAutoDetect.Visibility.ANY);
MAPPER.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES,
false);
-
MAPPER.setPropertyNamingStrategy(PropertyNamingStrategies.KebabCaseStrategy.INSTANCE);
+ // even though using new PropertyNamingStrategy.KebabCaseStrategy()
is deprecated
+ // and PropertyNamingStrategies.KebabCaseStrategy.INSTANCE
(introduced in jackson 1.14) is
+ // recommended, we can't use it because Spark still relies on
jackson 1.13.x stuff
Review Comment:
good catch, yes that should be 2.13.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
