nastra commented on code in PR #6835:
URL: https://github.com/apache/iceberg/pull/6835#discussion_r1108131096
##########
aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3ObjectMapper.java:
##########
@@ -48,13 +48,16 @@ public class S3ObjectMapper {
private S3ObjectMapper() {}
- static ObjectMapper mapper() {
+ public static ObjectMapper mapper() {
Review Comment:
you're right, making `initModule()` public is usually sufficient and should
be enough. It just felt weird to leave this non-public while making
`initModule()` public. I've reverted this change, since having public access to
`initModule()` works for our use case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
