amogh-jahagirdar commented on code in PR #6651:
URL: https://github.com/apache/iceberg/pull/6651#discussion_r1114858986
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkWriteConf.java:
##########
@@ -324,4 +325,12 @@ public boolean caseSensitive() {
.defaultValue(SQLConf.CASE_SENSITIVE().defaultValueString())
.parse();
}
+
+ public String branch() {
+ return confParser
+ .stringConf()
+ .option(SparkWriteOptions.BRANCH)
+ .defaultValue(SnapshotRef.MAIN_BRANCH)
Review Comment:
@rdblue @aokolnychyi @namrathamyske @jackye1995 As discussed in the
community sync, we'll remove the SQL write option from this PR and take that
separately since for row level operations there's more fundamental changes that
need to happen. I have those changes ready along with updated merge tests, so
I'll publish that so folks can take a look
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkPositionDeltaWriteBuilder.java:
##########
@@ -81,6 +82,11 @@ public DeltaWrite build() {
handleTimestampWithoutZone ||
!SparkUtil.hasTimestampWithoutZone(table.schema()),
SparkUtil.TIMESTAMP_WITHOUT_TIMEZONE_ERROR);
+ if (!writeConf.branch().equalsIgnoreCase(SnapshotRef.MAIN_BRANCH)) {
+ throw new UnsupportedOperationException(
+ "Row level operations on non-main branches are currently
unsupported");
+ }
Review Comment:
@rdblue @aokolnychyi @namrathamyske @jackye1995 This will prevent any row
level operations (temporarily until the SQL write config PR gets in) on
non-main branches.
Not entirely sure of a good way to test this because the only way to hit row
level writes is via SQL and we're removing the SQL config anyways. This is more
of a defensive measure in case there's a case for row level writes not via SQL
that we're missing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
