rdblue commented on code in PR #6651:
URL: https://github.com/apache/iceberg/pull/6651#discussion_r1115077997
##########
spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/sql/TestPartitionedWrites.java:
##########
@@ -31,11 +34,35 @@
import org.junit.Assert;
import org.junit.Before;
import org.junit.Test;
+import org.junit.runners.Parameterized;
public class TestPartitionedWrites extends SparkCatalogTestBase {
+
+ private String targetBranch;
+
public TestPartitionedWrites(
- String catalogName, String implementation, Map<String, String> config) {
+ String catalogName, String implementation, Map<String, String> config,
String targetBranch) {
Review Comment:
I'd prefer to copy the tests and add the VERSION AS OF to the copies rather
than adding a test param. Basically using the same logic as my comment above,
we still want to exercise the path that _doesn't_ use VERSION AS OF.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
