amogh-jahagirdar commented on code in PR #6651:
URL: https://github.com/apache/iceberg/pull/6651#discussion_r1115136867
##########
spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/source/TestDataFrameWrites.java:
##########
@@ -204,15 +223,26 @@ private void writeAndValidateWithLocations(Table table,
File location, File expe
}
private List<Row> readTable(String location) {
- Dataset<Row> result = spark.read().format("iceberg").load(location);
+ return readTable(location, SnapshotRef.MAIN_BRANCH);
+ }
+
+ private List<Row> readTable(String location, String branch) {
+ Dataset<Row> result =
+ spark.read().format("iceberg").option(SparkReadOptions.BRANCH,
branch).load(location);
Review Comment:
Good point, is it alright if I get this in a follow on PR before release?
That way the PR is focused on how we want to organize branch tests which I
think is a more fundamental thing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
