jackye1995 commented on code in PR #5888:
URL: https://github.com/apache/iceberg/pull/5888#discussion_r1116602078
##########
core/src/main/java/org/apache/iceberg/TableProperties.java:
##########
@@ -284,6 +284,10 @@ private TableProperties() {}
public static final String WRITE_AUDIT_PUBLISH_ENABLED = "write.wap.enabled";
public static final String WRITE_AUDIT_PUBLISH_ENABLED_DEFAULT = "false";
+ public static final String ROLLBACK_COMPACTION_ON_CONFLICTS_ENABLED =
Review Comment:
I think the name feels a bit awkward to me, first it's a commit time
feature, so I think it's better to make it start with `commit.`. Secondly this
is to rollback a REPLACE operation, so feels to me it's better to call it
something like `commit.rollback-replace-on-conflict-enabled`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
