jackye1995 commented on code in PR #5888:
URL: https://github.com/apache/iceberg/pull/5888#discussion_r1120526081
##########
core/src/main/java/org/apache/iceberg/BaseTransaction.java:
##########
@@ -73,6 +73,7 @@ enum TransactionType {
private TableMetadata current;
private boolean hasLastOpCommitted;
private final MetricsReporter reporter;
+ private boolean shouldRollbackCompaction;
Review Comment:
this name should be updated based on the config name
##########
core/src/main/java/org/apache/iceberg/BaseTransaction.java:
##########
@@ -73,6 +73,7 @@ enum TransactionType {
private TableMetadata current;
private boolean hasLastOpCommitted;
private final MetricsReporter reporter;
+ private boolean shouldRollbackCompaction;
Review Comment:
and seems like it's not used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
