nastra commented on code in PR #6091:
URL: https://github.com/apache/iceberg/pull/6091#discussion_r1122725274
##########
.palantir/revapi.yml:
##########
@@ -66,6 +66,10 @@ acceptedBreaks:
old: "method void org.apache.iceberg.io.DataWriter<T>::add(T)"
justification: "Removing deprecated method"
"1.1.0":
+ org.apache.iceberg:iceberg-api:
Review Comment:
we shouldn't introduce breaking API changes, but rather make
`deletedStatisticsFilesCount()` return 0 by default
##########
api/src/main/java/org/apache/iceberg/actions/ExpireSnapshots.java:
##########
@@ -109,5 +109,8 @@ interface Result {
/** Returns the number of deleted manifest lists. */
long deletedManifestListsCount();
+
+ /** Returns the number of deleted statistics files. */
+ long deletedStatisticsFilesCount();
Review Comment:
in order to not introduce breaking API changes, this should be a default
method and return 0, similar to how we did it in #6801
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
