nastra commented on code in PR #6091:
URL: https://github.com/apache/iceberg/pull/6091#discussion_r1123013096
##########
.palantir/revapi.yml:
##########
@@ -66,6 +66,10 @@ acceptedBreaks:
old: "method void org.apache.iceberg.io.DataWriter<T>::add(T)"
justification: "Removing deprecated method"
"1.1.0":
+ org.apache.iceberg:iceberg-api:
Review Comment:
In general if RevAPI is complaining about something, then it's a breaking
API change. We just need to be careful that we only add API breaks that we
previously deprecated as defined in
https://github.com/apache/iceberg/blob/master/CONTRIBUTING.md#major-version-deprecations-required
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
