rdblue commented on code in PR #7011:
URL: https://github.com/apache/iceberg/pull/7011#discussion_r1129649782
##########
spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/source/TestPositionDeletesTable.java:
##########
@@ -230,9 +230,17 @@ public void testSplitTasks() throws IOException {
Table deleteTable =
MetadataTableUtils.createMetadataTableInstance(tab,
MetadataTableType.POSITION_DELETES);
- Assert.assertTrue(
- "Position delete scan should produce more than one split",
- Iterables.size(deleteTable.newBatchScan().planTasks()) > 1);
+
+ if (format.equals(FileFormat.AVRO)) {
+ Assert.assertTrue(
+ "Position delete scan should produce more than one split",
+ Iterables.size(deleteTable.newBatchScan().planTasks()) > 1);
+ } else {
+ Assert.assertEquals(
+ "Position delete scan should produce one split",
+ 1,
+ Iterables.size(deleteTable.newBatchScan().planTasks()));
+ }
Review Comment:
Avro uses 1 MB blocks so the split offsets don't need to be stored. There
would be a ton of them (hundreds per file) and they aren't very useful in
planning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
