szehon-ho commented on code in PR #7011:
URL: https://github.com/apache/iceberg/pull/7011#discussion_r1130173498
##########
core/src/test/java/org/apache/iceberg/TestSplitPlanning.java:
##########
@@ -249,6 +249,23 @@ public void testBasicSplitPlanningDeleteFiles() {
Assert.assertEquals(8,
Iterables.size(posDeletesTable.newBatchScan().planTasks()));
}
+ @Test
+ public void testBasicSplitPlanningDeleteFilesWithSplitOffsets() {
+ table.updateProperties().set(TableProperties.FORMAT_VERSION, "2").commit();
+ List<DeleteFile> files128Mb = newDeleteFiles(4, 128 * 1024 * 1024, 8);
+ appendDeleteFiles(files128Mb);
+
+ PositionDeletesTable posDeletesTable = new PositionDeletesTable(table);
+ // we expect 8 bins since split size is 64MB
+ Assert.assertEquals(
Review Comment:
> thinking if there is a way to test this i.e finding if these tasks were
merged into new task
Trying to follow, are we going to add another test for this case? (For if
the tasks can be merged further, with larger split size?) I think that is good
with me, if I didn't mis-understand you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
