amogh-jahagirdar commented on code in PR #7046:
URL: https://github.com/apache/iceberg/pull/7046#discussion_r1134170038
##########
aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java:
##########
@@ -70,8 +70,8 @@
private static final Cache<Key, SignedComponent> SIGNED_COMPONENT_CACHE =
Caffeine.newBuilder().expireAfterWrite(30,
TimeUnit.SECONDS).maximumSize(100).build();
- private static final ScheduledExecutorService TOKEN_REFRESH_EXECUTOR =
- ThreadPools.newScheduledPool("s3-signer-token-refresh", 1);
+ private static final AtomicReference<ScheduledExecutorService>
TOKEN_REFRESH_EXECUTOR =
Review Comment:
`AtomicReference` is something I've been pushing just because it leads to
shorter more readable code Imo but I'm not super opinionated on this, since the
rest of the code base follows a good convention we can just follow that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
