amogh-jahagirdar commented on code in PR #7046:
URL: https://github.com/apache/iceberg/pull/7046#discussion_r1134178777
##########
aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java:
##########
@@ -113,26 +115,44 @@ boolean keepTokenRefreshed() {
OAuth2Properties.TOKEN_REFRESH_ENABLED_DEFAULT);
}
+ private ScheduledExecutorService tokenRefreshExecutor() {
Review Comment:
I think it can be if we move the `if (!keepTokenRefreshed())` out of the
method and go back to the ternary operator we had . everything else looks
static.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
