szehon-ho commented on code in PR #7361:
URL: https://github.com/apache/iceberg/pull/7361#discussion_r1174186347
##########
api/src/main/java/org/apache/iceberg/actions/RewriteDataFiles.java:
##########
@@ -197,6 +197,11 @@ default int rewrittenDataFilesCount() {
default long rewrittenBytesCount() {
return
rewriteResults().stream().mapToLong(FileGroupRewriteResult::rewrittenBytesCount).sum();
}
+
+ @Value.Default
Review Comment:
Instead of re-using the FileGroupRewriteResult, would it make more sense to
have a FailedFileGroupRewriteResult, with just failure?
I dont think the bytesCount/fileCount make too much sense on failure, and we
can also put the exception there? cc @aokolnychyi @RussellSpitzer for thoughts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
